Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move] Fix test_scenario tests #5153

Merged
merged 1 commit into from
Oct 12, 2022
Merged

[move] Fix test_scenario tests #5153

merged 1 commit into from
Oct 12, 2022

Conversation

tnowacki
Copy link
Contributor

  • Fix failing test scenario tests
  • Added missing cases

@tnowacki
[move] Fix test_scenario tests
c36c11f 
- Fix failing test scenario tests
- Added missing cases
@tnowacki tnowacki requested a review from damirka October 12, 2022 17:08
@sblackshear
Copy link
Collaborator

Do we know why these weren't breaking CI?

@damirka
Copy link
Contributor

damirka commented Oct 12, 2022

Do we know why these weren't breaking CI?
It's a different issue. This buddy fixes failing tests which is super helpful rn. And we're in the process.

@tnowacki tnowacki merged commit 0136a53 into MystenLabs:main Oct 12, 2022
@tnowacki
Copy link
Contributor Author

Do we know why these weren't breaking CI?
It's a different issue. This buddy fixes failing tests which is super helpful rn. And we're in the process.

#5152

@tnowacki tnowacki deleted the test-fix branch March 31, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damirka damirka damirka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnowacki @sblackshear @damirka