crypto: fix ecdsa module name in example #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchalkias
reviewed
Oct 12, 2022
| @@ -26,7 +26,7 @@ module math::ecdsa { | |||
| public entry fun keccak256(data: vector<u8>, recipient: address, ctx: &mut TxContext) { | |||
There was a problem hiding this comment.
Irrelevant to this PR, but why this keccak function lives here under ECDSA?
There was a problem hiding this comment.
yeah we want to put it in something like hash.move
huitseeker
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some reason the renaming of packages was not checked against this example contract