Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changesets] Update changeset CI to include warning #5029

Merged
merged 6 commits into from
Oct 11, 2022

Conversation

Jordan-Mysten
Copy link
Contributor

@Jordan-Mysten Jordan-Mysten commented Oct 6, 2022

This introduces a new step to the changeset CI validation, which checks to see if there have been changes to public packages, and if there are changesets present. If there are package changes but no changeset, it will comment on the PR warning the user that they may need to add a changeset. The comment is deleted when changesets are added.

I had to use the same workflow_run indirection I used in the wallet comment PR to make this work seamlessly for PRs from forks.

@Jordan-Mysten Jordan-Mysten marked this pull request as ready for review October 6, 2022 19:17
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3200001092#artifacts

@Jordan-Mysten Jordan-Mysten requested a review from 666lcz October 6, 2022 19:55
@Jordan-Mysten Jordan-Mysten changed the title [WIP] Update changeset CI to include warning [changesets] Update changeset CI to include warning Oct 6, 2022
Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the warning!

@Jordan-Mysten Jordan-Mysten merged commit 2faa831 into main Oct 11, 2022
@Jordan-Mysten Jordan-Mysten deleted the jordan--changeset-warning branch October 11, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants