Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: fix OnlyPublishToCratesIo and PublishedPackagesDontDependOnUnpu… #4953

Merged
merged 1 commit into from
Oct 3, 2022
Merged

lint: fix OnlyPublishToCratesIo and PublishedPackagesDontDependOnUnpu… #4953

merged 1 commit into from
Oct 3, 2022

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Oct 3, 2022

…blishedPackages

@bmwill bmwill requested a review from mwtian October 3, 2022 22:29
mwtian
mwtian approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@mwtian mwtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmwill! When we want to publish Narwhal packages, do we need to remove all publish = false from Narwhal crates and transitive deps, then fix up broken builds?

@bmwill
Copy link
Contributor Author

bmwill commented Oct 3, 2022

If/when we publish then we'll need to be very careful with our dependencies and is one of the main reason these lints exist, to enable clean publishing of crates from within a workspace.

@bmwill bmwill enabled auto-merge (squash) October 3, 2022 23:08
@bmwill bmwill merged commit 69a29b4 into MystenLabs:main Oct 3, 2022
@bmwill bmwill deleted the lints branch June 9, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwtian mwtian mwtian approved these changes

@asonnino asonnino Awaiting requested review from asonnino

@akichidis akichidis Awaiting requested review from akichidis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmwill @mwtian