-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sui CLI] Unit test Sui cli - Part 2 #452
Conversation
155d2fe
to
3926605
Compare
There might be a bug in tracing-test crate, I couldn't get the traced_test macro working in the second test file, so I put all test in cli_test.rs for now, will investigate when have more bandwidth. This PR tests synchronise and retrieve objects logic in Sui, should be good enough to ensure basic functionality working for Sui cli and the wallet, will add more test in future PR. |
decd4bf
to
e3dacf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be a bug in tracing-test crate, I couldn't get the traced_test macro to working in the second test file, so I put all test in cli_test.rs for now, will investigate when have more bandwidth.
I'm a bit confused: what was the original issue, in which configuration did you encounter it, and what was the workaround?
I had 2 test files in the original configuration, "sui_tests.rs" and "wallet_tests.rs", one for each binary, the test in sui_tests.rs runs fine, the logs are printed to the console and All tests are annotated with the The workaround is to put all the test in 1 file. |
test_objects_command
is an integration test starting up a network usingSui start
and retrieve informations from the authorities.This PR include moving Sui commands, wants to merge in earlier to unblock other task.