Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explorer] Update Transaction Results Status Message to Reflect Figma #4485

Merged
merged 13 commits into from
Sep 7, 2022
Merged

[Explorer] Update Transaction Results Status Message to Reflect Figma #4485

merged 13 commits into from
Sep 7, 2022

Conversation

apburnie
Copy link
Contributor

@apburnie apburnie commented Sep 6, 2022 •
edited
Loading

  • Adds Info SVG icon and implements in case of Transaction Failure
  • Rounds the border of the Transaction Failure Explanation Message
  • Adds to the custom Tailwind themes issue dark/light and success DEFAULT/dark/light.
  • Implements the new themes across the Transaction Failure Message, Transaction Success Message and the Recent Transactions Table.
  • Replaces word 'failed' with 'failure'
  • Increases status message font weight from normal to medium

The below screenshots have been updated to reflect the latest changes as of 7 Sep 2022

Transaction Failure Message

image
image

Transaction Success Message

image
image

Recent Transactions

image

@apburnie apburnie marked this pull request as ready for review September 6, 2022 15:03
@apburnie apburnie mentioned this pull request Sep 6, 2022
Merged
@apburnie apburnie self-assigned this Sep 6, 2022
stella3d
stella3d approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@stella3d stella3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
i notice that the capitalize CSS doesn't seem to be working, but that wasn't added here

mystie711
mystie711 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@mystie711 mystie711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great.

@apburnie apburnie merged commit 624aafa into main Sep 7, 2022
@apburnie apburnie deleted the txFailMsgUpdate branch September 7, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mystie711 mystie711 mystie711 approved these changes

@stella3d stella3d stella3d approved these changes

@Jibz1 Jibz1 Jibz1 approved these changes

@666lcz 666lcz Awaiting requested review from 666lcz

@Jordan-Mysten Jordan-Mysten Awaiting requested review from Jordan-Mysten

Assignees

@apburnie apburnie

Labels
sui-explorer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apburnie @Jibz1 @stella3d @mystie711