Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts-sdk] Remove TSDX, replace with tsup / vitest #4392

Merged
merged 6 commits into from
Aug 30, 2022

Conversation

Jordan-Mysten
Copy link
Contributor

This replaces #4143, and does the work for both bcs and the TS SDK, since they're the final TSDX consumers. I mirrored the build process from the wallet adapters, which seems to work well.

@Jordan-Mysten Jordan-Mysten marked this pull request as ready for review August 30, 2022 21:09
@@ -55,6 +55,7 @@
"jest": "^28.1.3",
"mini-css-extract-plugin": "^2.6.1",
"onchange": "^7.1.0",
"postcss": "^8.4.6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just silencing an install peer dep warning tree.

Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I am amazed by how fast the tests are running now

@Jordan-Mysten Jordan-Mysten merged commit c5e4851 into main Aug 30, 2022
@Jordan-Mysten Jordan-Mysten deleted the jordan--remove-tsdx branch August 30, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants