[Explorer] Adds Amount Field to TransferSui Page #3949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
666lcz
reviewed
Aug 12, 2022
explorer/client/src/pages/transaction-result/TransactionView.tsx
Outdated
Show resolved
Hide resolved
explorer/client/src/pages/transaction-result/TransactionView.tsx
Outdated
Show resolved
Hide resolved
explorer/client/src/pages/transaction-result/TransactionView.tsx
Outdated
Show resolved
Hide resolved
apburnie
changed the title
apburnie
requested review from
666lcz,
Jibz1,
stella3d,
Jordan-Mysten and
mystie711
mystie711
suggested changes
Aug 15, 2022
There was a problem hiding this comment.
UI delta feedback captured here,
https://www.figma.com/file/YJt9Bs4eyhD9PmeZQbFTkf/dev-feedback?node-id=26%3A12
|
Additionally @Andrew47, for mobile breakpoints, please move the "date" info below "Sender & Recipient" title instead of to it's right. |
Jordan-Mysten
approved these changes
Aug 15, 2022
apburnie
force-pushed
the
updateTransferSuiView
branch
from
472e9fa to
7054ccd
Compare
|
@mystie711 --> Here's the new Design Desktop: Mobile: Space has been added between the number and SUI, the date now goes to a new line in mobile and the space between sender and recipient address has been reduced. The font weights follow the Figma spec. I'm not sure I can see a major difference. Some of it may be rendering differences between Firefox and Chrome. |
|
Looking good @Andrew47. Ship it! |
mystie711
approved these changes
Aug 16, 2022
apburnie
force-pushed
the
updateTransferSuiView
branch
from
7054ccd to
076eab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the amount field to the TransferSui Page as well as removing TransferSui from the tabs labels.
Desktop
Mobile