Fix a bug where transfer sui with insufficient gas still lead the object to be transferred #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnowacki
reviewed
Aug 1, 2022
tnowacki
approved these changes
Aug 1, 2022
lxfind
force-pushed
the
transfer-sui-fix-insufficient-gas-bug
branch
from
23dfd39 to
0a77bc7
Compare
huitseeker
pushed a commit
to huitseeker/sui
that referenced
this pull request
Aug 1, 2022
…ect to be transferred (MystenLabs#3675) * Add tests * Fix insuffiicent gas bug
huitseeker
pushed a commit
that referenced
this pull request
Aug 1, 2022
…ect to be transferred (#3675) * Add tests * Fix insuffiicent gas bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is an error due to insufficient gas, we clear the temporary store.
However, in code latter we deduct and update gas on the old object before we cleared the temporary store, and write it into the store. This essentially override the cleared state.
This part of the code is not very clean and probably worth some refactoring to make it less error prone.
This PR resolves #3632.