[Client Refactoring 2] Add a stateless version of execution_transaction
#360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to move
execution_transaction
to AuthorityAggregator, we first introduce a stateless version of it, and call it from the stateful version. This stateless version will then latter be moved to AuthorityAggregator.The reason I am doing it this way is to make PRs less intrusive / easier to review, and make the refactoring more smooth. It also allows other people to continue working on the client core.
Most of this PR is straightforwards as most functions called are already stateless.
The only thing I needed to change is to move around the update of local objects. There are two of them, once in the
execution_transaction
, while the other one inexecute_transaction_without_confirmation
. The one inexecute_transaction_without_confirmation
is unnecessary and can be removed.