Don't sync in Authority Aggregator #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdanezis
approved these changes
Jul 29, 2022
| .collect(); | ||
|
|
||
| let (_active_objects, _deleted_objects) = | ||
| self.sync_all_given_objects(&required_ids).await?; |
There was a problem hiding this comment.
Not sure how far you want to go with this. However, if you also remove sync_account_state (as suggested here #1045) you can also remove sync_all_owned_objects which is the only call site of sync_all_given_objects, and thus you can remove that too.
huitseeker
pushed a commit
to huitseeker/sui
that referenced
this pull request
Aug 1, 2022
huitseeker
pushed a commit
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have gossip + checkpoint + execution_driver, we should no longer need the object sync when processing a transaction in the authority aggregator.