Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Studio 2022 Preview to Microsoft Windows dependencies #3507

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

Clay-Mysten
Copy link
Contributor

No description provided.

@Clay-Mysten Clay-Mysten requested a review from patrickkuo July 26, 2022 16:19
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Jul 26, 2022
@@ -174,6 +174,8 @@ In macOS, other than the aforementioned [Brew](#brew) package manager, the gener

In Microsoft Windows, also install:

[Visual Studio 2022 Preview](https://visualstudio.microsoft.com/vs/preview/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should mention that this is only applicable to Windows on ARM64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should mention that this is only applicable to Windows on ARM64

Done. Thanks for the reminder!

@Clay-Mysten Clay-Mysten requested a review from patrickkuo July 26, 2022 16:44
Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the change.

@Clay-Mysten Clay-Mysten merged commit b9ad041 into main Jul 26, 2022
@Clay-Mysten Clay-Mysten deleted the Clay-Mysten-patch-9 branch July 26, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants