Edit Rust SDK doc, add links to supporting docs #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Documentation
randall-Mysten
approved these changes
Jul 25, 2022
doc/src/build/rust-sdk.md
Outdated
| ```toml | ||
| [dependencies] | ||
| sui-sdk = { git = "https://github.com/MystenLabs/sui", branch = "devnet" } | ||
| ``` | ||
| TODO: Give them a little more guidance on what this file is and where to find it. We describe `Move.toml` more fully at: |
There was a problem hiding this comment.
this is intentionally public viewable?
There was a problem hiding this comment.
this is intentionally public viewable?
Yep. Let's have Patrick review before merge.
There was a problem hiding this comment.
I am expecting the audience of this doc knows the basic of Rust and Cargo.toml, I don't think we need more descriptions here?
There was a problem hiding this comment.
I am expecting the audience of this doc knows the basic of Rust and
Cargo.toml, I don't think we need more descriptions here?
Great. I removed the TODO and linked into the Cargo doc.
punwai
force-pushed
the
Clay-Mysten-patch-4
branch
2 times, most recently
from
29dc43a to
0c18b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.