Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Ed25519Keypair.fromDerivePath method (#2900)" #3436

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented Jul 22, 2022

This reverts commit 32d3047.

#2900 broke the CI and caused all DApps that depends on the SDK to add polyfills. We are temporarily reverting this commit until we find a way to avoid this.

Module not found: Error: Can't resolve 'crypto' in '/home/runner/work/sui/sui/explorer/client/node_modules/@mysten/sui.js/node_modules/bip39-light'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
	- install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "crypto": false }
ERROR in ./node_modules/@mysten/sui.js/node_modules/bip39-light/index.js9:16-45
Module not found: Error: Can't resolve 'crypto' in '/home/runner/work/sui/sui/explorer/client/node_modules/@mysten/sui.js/node_modules/bip39-light'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
	- install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "crypto": false }
ERROR in ./node_modules/@mysten/sui.js/node_modules/cipher-base/index.js3:16-43
Module not found: Error: Can't resolve 'stream' in '/home/runner/work/sui/sui/explorer/client/node_modules/@mysten/sui.js/node_modules/cipher-base'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }'
	- install 'stream-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "stream": false }
webpack compiled with 2 errors

@666lcz 666lcz requested a review from stella3d July 22, 2022 21:28
@666lcz 666lcz enabled auto-merge (squash) July 22, 2022 21:29
@666lcz 666lcz merged commit 67117cc into main Jul 22, 2022
@666lcz 666lcz deleted the chris-revert-2900 branch July 22, 2022 21:31
@daoauth
Copy link
Contributor

daoauth commented Sep 2, 2022

The sui wallet uses bip39-light, but will things get better if I switch to the more stable @scure/bip39?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants