Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanups in authority_tests #338

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Some cleanups in authority_tests #338

merged 1 commit into from
Feb 2, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Feb 2, 2022 •
edited
Loading

A few cleanups:

  1. Creating a new move object is a common need in the tests. Made a function for it.
  2. Calling ObjectBasics is a common need. Made a function for it. This will also make it easier for us to migrate away from ObjectBasics latter.
  3. There are a few redundant genesis object settings, removing them.

@lxfind lxfind force-pushed the cleanup-authority-tests branch from a1d8c32 to 2ae901f Compare February 2, 2022 00:52
gdanezis
gdanezis approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@gdanezis gdanezis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this!

@lxfind lxfind force-pushed the cleanup-authority-tests branch from 2ae901f to 6e7f43a Compare February 2, 2022 15:42
@lxfind lxfind merged commit 356c161 into main Feb 2, 2022
@lxfind lxfind deleted the cleanup-authority-tests branch February 2, 2022 16:01
@lxfind lxfind restored the cleanup-authority-tests branch February 2, 2022 16:01
@lxfind lxfind deleted the cleanup-authority-tests branch February 2, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdanezis gdanezis gdanezis approved these changes

@huitseeker huitseeker Awaiting requested review from huitseeker

@sblackshear sblackshear Awaiting requested review from sblackshear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lxfind @gdanezis