Retry failed requests in benchmark #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadhansood
force-pushed
the
sadhan/benchmark
branch
from
48cccb7 to
ca61019
Compare
huitseeker
approved these changes
Jul 11, 2022
| // TODO (GAS-LEAK): How do we add this gas back in the pool? | ||
| NextOp::Response(None) | ||
| // eprintln!("{}", sui_err); | ||
| NextOp::Retry(Box::new((tx, counter_id, owner))) | ||
| } | ||
| _ => { | ||
| // eprintln!("error"); |
There was a problem hiding this comment.
I'd nix those prints or make the logs while we're at it.
| @@ -236,7 +237,7 @@ async fn main() { | |||
| make_counter_increment_transaction(gas.1 .0, package_ref, counter_id); | |||
| let res = qd | |||
| .execute_transaction(ExecuteTransactionRequest { | |||
| transaction: tx, | |||
| transaction: tx.clone(), | |||
There was a problem hiding this comment.
yes, because we are moving the tx object later on
Comment on lines
288
to
295
| Err(_sui_err) => { | ||
| //eprintln!("{}", _sui_err); | ||
| NextOp::Retry(b) | ||
| } | ||
| _ => { | ||
| // eprintln!("error"); | ||
| NextOp::Retry(b) | ||
| } |
There was a problem hiding this comment.
Those can probably de made more compact.
There was a problem hiding this comment.
hopefully addresses
| .map(move |res| { | ||
| match res { | ||
| Ok(ExecuteTransactionResponse::EffectsCert(result)) => { | ||
| let (_, effects) = *result; |
There was a problem hiding this comment.
You can put this destructuring pattern in the line right above.
There was a problem hiding this comment.
I tried, but looks like i cannot destruct the Box<> inside the EffectsCert
sadhansood
force-pushed
the
sadhan/benchmark
branch
3 times, most recently
from
e8367e1 to
7dc85db
Compare
sadhansood
force-pushed
the
sadhan/benchmark
branch
from
7dc85db to
f7f632d
Compare
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can retry the failed requests and expect to get effects from the transaction digest if the previous one went through or submit a new one again