[crypto] Unify Narwhal and Sui Crypto

[punwai]

This PR relies on: https://github.com/MystenLabs/narwhal/pull/460/files

• All implementations of cryptographic primitives are moved over to the Narwhal repository (except AccountSignatures/Signature for now). Authority Signatures are now completely generic.
• Added 'batch verification' on another PR in narwhal that will allow us to plug any batched signature into Sui
• More generic and cleaner version of add bls signatures support #2877

Next to dos:

• Change PublicKeyBytes to an Associated Type? This will massively help me out when implementing other things

[punwai]

@kchalkias @huitseeker Would love if you could have a look through this!

[huitseeker]

Promising ! 🚀

[punwai]

Required because of polymorphism

[huitseeker]

I don't get it: neither rust not me have any issue with

impl From<&PublicKeyBytes> for SuiAddress {
    fn from(pkb: &PublicKeyBytes) -> Self {
        let mut hasher = Sha3_256::default();
        hasher.update(pkb.as_ref());
        let g_arr = hasher.finalize();

        let mut res = [0u8; SUI_ADDRESS_LENGTH];
        res.copy_from_slice(&AsRef::<[u8]>::as_ref(&g_arr)[..SUI_ADDRESS_LENGTH]);
        SuiAddress(res)
    }
}

what's the idea that drove you to this?

You can also use this alongside the first:

impl From<&PublicKey> for SuiAddress {
    fn from(pkb: &PublicKey) -> Self {
        let mut hasher = Sha3_256::default();
        hasher.update(pkb.as_ref());
        let g_arr = hasher.finalize();

        let mut res = [0u8; SUI_ADDRESS_LENGTH];
        res.copy_from_slice(&AsRef::<[u8]>::as_ref(&g_arr)[..SUI_ADDRESS_LENGTH]);
        SuiAddress(res)
    }
}

[punwai]

I think the problem was me trying to implement PublicKey when it was a derivation of Keypair. I don't quite understand why that was a problem, but now that we remove all that gunk we should be fine.

Resolved!

[kchalkias]

Amazing! good to go