[core] Set the no_more_fragments correctly
#2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Is there a test that can trigger the no_more_fragments case? |
lxfind
approved these changes
Jun 25, 2022
|
Good point -- will add a test! |
gdanezis
force-pushed
the
fix-reconstruct-contents
branch
from
55f1291 to
24ab113
Compare
punwai
pushed a commit
that referenced
this pull request
Jun 30, 2022
* Set the `no_more_fragments` correctly * Added test Co-authored-by: George Danezis <george@danez.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently set the
no_more_fragmentsflag only when there is no current proposal in a location where this may never happen, and do not set it when the checkpoint reconstruction succeeds but does not include this validator. In this fix, we now set theno_more_fragmentsif our two strategies for recovering the checkpoint fail.