Restore test_full_node_cold_sync and make it less fragile #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longbowlu
reviewed
Jun 23, 2022
| let (_, _, _, _) = transfer_coin(&mut context).await?; | ||
| let (_transfered_object, _sender, _receiver, digest) = transfer_coin(&mut context).await?; | ||
|
|
||
| sleep(Duration::from_millis(1000)).await; |
There was a problem hiding this comment.
we should sleep after wait_for_tx, right?
Let's add a comment on why we sleep here
There was a problem hiding this comment.
This sleep is to make sure that the authorities are quiescent before we start up the node - if they aren't, its not really a cold sync.
velvia
approved these changes
Jun 23, 2022
longbowlu
approved these changes
Jun 23, 2022
|
@velvia It was accidentally deleted in my PR, probably due to rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.