Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sui framework] Adds mint_and_transfer and burn_ entrypoints, changes argument order in mint() #2655
[sui framework] Adds mint_and_transfer and burn_ entrypoints, changes argument order in mint() #2655
Changes from 3 commits
01c1110
ff9e5e4
699fb59
a485413
1a5f33c
5c87b32
f8c3988
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree with the requirement of having entry functions for these flows (as it will help new Coins to be created in just a few lines of code), but we need to agree on the naming convention. Is the
_
the pattern we're looking for as best practice here ormint_to_sender
etc? @tnowackiThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
_
convention was from when you actually needed a separate function for visibility reasons.This feels a bit different though since the functionality is actually different. I would advise something like
mint_and_transfer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tnowacki what do you think about burn_ in that context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one where it drops the
u64
? Feels okay.I would ask yourself, What would the
and_<verb>
version be? If it is un-interesting, just an_
is fine. If its something likeand_transfer_to_someone
, you probably want a different name or suffixThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way!