Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared_object_sync test #2562

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Fix shared_object_sync test #2562

merged 1 commit into from
Jun 15, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Jun 15, 2022

The test has been flaky because of gossip, which was introducing non-deterministic behavior.
Disable gossip by default in these tests.
This fixes #2530

@lxfind lxfind requested a review from asonnino June 15, 2022 00:46
Copy link
Contributor

@asonnino asonnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@lxfind lxfind merged commit ea0c9ec into main Jun 15, 2022
@lxfind lxfind deleted the fix-shared-object-sync-test branch June 15, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test shared_object_sync fails sometimes
2 participants