-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable write-ahead log, recover in-progress TXes at startup. #2518
Conversation
da148b1
to
b9bfabb
Compare
d212930
to
653f664
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one -- I have a few questions around the "pop" in the recovery logic; the conditions under which we might retry; as well as deleting from the retry table.
@gdanezis thanks for the excellent comments, will address the ones that require edits! |
ab87ae5
to
54eca27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left lots of comments.... good work @mystenmark
If a poison pill tx is ever found (that somehow crashes the validator) we must stop retrying it every time we restart.
6a420da
to
a3fd102
Compare
A few items are still TODO: