Event Store Initial Implementation #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longbowlu
reviewed
Jun 10, 2022
| // to execute all inserts in a single statement? | ||
| // TODO: See https://kerkour.com/high-performance-rust-with-sqlite | ||
| for event in events { | ||
| // If batching, turn off persistent to avoid caching as we may fill up the prepared statement cache |
There was a problem hiding this comment.
curious when does the cache get flushed?
| /// Will return at most limit of the most recent events within the window, sorted in ascending time. | ||
| fn events_by_module_id( | ||
| /// Will return at most limit of the most recent events within the window, sorted in descending time. | ||
| async fn events_by_module_id( |
|
@longbowlu pushed a new commit to address most of your comments. Move event test also coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of the
EventStoretrait (and some modifications to it) based on SQLite and thesqlxcrate.Methods are enough for basic event store queries by event type and module/package ID, per events implementation plan.
NOTE: The choice to have a JSON field is to allow for easy filtering of any field within Move events and other events. However, it would take up more space and duplicate the binary data in a BCS field.
Also it gives flexibility to add more fields to other events in the future without having to dedicate a column to each.
The idea is that the separate columns are the main ones used for filtering things down.
To be added: