[core] Add effects digest to follower API + checkpoints #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fulfils 1/4 items in #2039 |
lxfind
approved these changes
Jun 6, 2022
crates/sui-types/src/base_types.rs
Outdated
| pub struct TransactionEffectsDigest( | ||
| #[schemars(with = "Base64")] | ||
| #[serde_as(as = "Readable<Base64, Bytes>")] | ||
| pub [u8; TRANSACTION_DIGEST_LENGTH], | ||
| pub [u8; 32], |
There was a problem hiding this comment.
Good point, let me put it back in!
gdanezis
force-pushed
the
add-effects-to-follower
branch
from
fef1812 to
34baf4d
Compare
stella3d
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Add structures for ExecutionDigest * Into point * Add effects digest to follower / checkpoints * Add const length Co-authored-by: George Danezis <george@danez.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the information in
UpdateItemssent by the follower API, as well as the information stored in checkpoints from only containing aTransactionDigestto also containing theTransactionEffectsDigest, in a new structure that we callExecutionDigest.