Skip to content

Add transaction scheduler #22009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: xun/add-wait-functions-cache
Choose a base branch
from

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Apr 30, 2025

Description

This PR removes the TransactionManager module, and replace it with a new ExecutionScheduler.
This scheduler no longer uses a cache to manage object dependency explicitly. Instead, it now uses the newly added notify_wait_input_object function to wait on the input objects directly in a tokio thread.
It also refactors the per-object congestion queue to a separate file for better clarity.

Test plan

Ported all the old tests over to the new module.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 4:16am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 6, 2025 4:16am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 6, 2025 4:16am

@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env April 30, 2025 03:51 — with GitHub Actions Inactive
@lxfind lxfind force-pushed the xun/add-tx-manager-v2 branch from ca86d60 to 617ddcc Compare May 6, 2025 03:59
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env May 6, 2025 03:59 — with GitHub Actions Inactive
@lxfind lxfind changed the title Xun/add tx manager v2 Add transaction scheduler May 6, 2025
@lxfind lxfind changed the base branch from main to xun/add-wait-functions-cache May 6, 2025 03:59
@lxfind lxfind marked this pull request as ready for review May 6, 2025 04:01
@lxfind lxfind requested a review from a team as a code owner May 6, 2025 04:01
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env May 6, 2025 04:01 — with GitHub Actions Inactive
@lxfind lxfind requested a review from mystenmark May 6, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant