[move] Add test-ony coverage gathering and differential test coverage #22007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/move-lcov-differential-coverage
branch
from
b97a62a to
75ac6e4
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/move-lcov-differential-coverage
branch
from
75ac6e4 to
24c03da
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/move-lcov-differential-coverage
branch
from
24c03da to
378924b
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
approved these changes
May 2, 2025
Comment on lines
+53
to
+56
| differential: Option<String>, | ||
| /// Compute coverage for the provided test name. Only this test will contribute to the | ||
| /// coverage calculation. | ||
| #[clap(long = "only-test", conflicts_with = "differential")] |
There was a problem hiding this comment.
Should this be an enum? Or is that more trouble than it is worth?
There was a problem hiding this comment.
I looked into it and it's possible, but I'd classify it as more trouble than it's worth and leads to a (IMHO) slightly weird command texture where differential and only-test become subcommands as opposed to args/flags.
tzakian
force-pushed
the
tzakian/move-lcov-support
branch
from
2b75801 to
9adaf27
Compare
tzakian
force-pushed
the
tzakian/move-lcov-differential-coverage
branch
from
378924b to
a082257
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/move-lcov-support
branch
from
9adaf27 to
f2d7eca
Compare
tzakian
force-pushed
the
tzakian/move-lcov-differential-coverage
branch
from
a082257 to
bad1f36
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
added a commit
that referenced
this pull request
May 12, 2025
…#22007) ## Description This builds on top of the LCOV support for Move in the PR below this to add two new commands: * `--only-test <test-name>` where `test-name` is the name of the test (can be either the function name or `module_name::function_name` of the test). * `--differential-test <test-name>` this computes the "differential coverage" as inspired by [this article](https://research.swtch.com/diffcover). Basically for a test `T` - If the code is hit only by `T` then it will show as "covered" - If the code is hit by both `T` and other tests than it will show as "uncovered" - If the code is either not hit at all, or only by other tests, then it will not show up as covered/uncovered at all. ## Test plan Added tests to the Move CLI for this. Some examples of the output ``` move coverage lcov ```  ``` move coverage lcov --only-test f21 ```  ``` move coverage lcov --differential-test f21 ```  --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [X] CLI: Adds support for more advanced LCOV-based Move coverage information -- both individual and differential test summary information is now supported. - [ ] Rust SDK:
tzakian
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This builds on top of the LCOV support for Move in the PR below this to add two new commands:
--only-test <test-name>wheretest-nameis the name of the test (can be either the function name ormodule_name::function_nameof the test).--differential-test <test-name>this computes the "differential coverage" as inspired by this article. Basically for a testTTthen it will show as "covered"Tand other tests than it will show as "uncovered"Test plan
Added tests to the Move CLI for this.
Some examples of the output
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.