[pkg-alt] Switch to JSON RPC for external resolvers #21998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
force-pushed
the
package-alt
branch
from
e861d94 to
4217bd2
Compare
mdgeorge4153
changed the title
7 tasks
mdgeorge4153
force-pushed
the
package-alt
branch
2 times, most recently
from
8b62f9a to
7bb6fd6
Compare
mdgeorge4153
force-pushed
the
mdgeorge/resolution-3
branch
from
b9d2e39 to
f9d3fb0
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This adds several tests for different external resolver scenarios, providing good coverage for both success and error cases. It also fixes a bug in external resolution - previously we did not output dep-overrides if the external resolver returned different values for the same dep in different environments. Finally, we changed the display for dependency sets to make snapshots more readable / diffable. Integration tests --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
mdgeorge4153
force-pushed
the
mdgeorge/resolution-3
branch
from
c3396ac to
963027b
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.