jsonrpc: make coin_api cursors opaque #21137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Feb 7, 2025
| @@ -868,7 +867,7 @@ impl RpcExampleProvider { | |||
| .collect::<Vec<_>>(); | |||
| let page = CoinPage { | |||
| data: coins, | |||
| next_cursor: Some(next), | |||
| next_cursor: Some("abcd".to_string()), | |||
There was a problem hiding this comment.
Do the values end up appearing in the examples at all? If so it would be good to use something that's recognisably Base64?
There was a problem hiding this comment.
while it may be base64 encoded, the fact that it is is not part of the api contract as it really does need to be "opaque".
Explicitly make the cursors for get_coins and get_all_coins to be an opaque string instead of an ObjectId encoded as a string.
bmwill
force-pushed
the
jsonrpc-get-coins
branch
from
e7c6fbc to
62420e7
Compare
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This was referenced Feb 14, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly make the cursors for get_coins and get_all_coins to be an opaque string instead of an ObjectId encoded as a string.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
Explicitly make the cursors for GetCoins and GetAllCoins to be an opaque string instead of an ObjectId encoded as a string.