Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GA4 to explorer and cookie consent #2086

Merged
merged 2 commits into from
May 24, 2022
Merged

Conversation

Jibz1
Copy link
Contributor

@Jibz1 Jibz1 commented May 19, 2022

GA added to explorer.

Screen Shot 2022-05-19 at 7 20 59 PM

Screen Shot 2022-05-19 at 7 21 21 PM

Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

// SPDX-License-Identifier: Apache-2.0
import ReactGA from 'react-ga4';
ReactGA.initialize('G-96DM59YK2F');
ReactGA.send('pageview');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do if we want to collect more fine-grained events, e.g., collect event for object view, transaction view, click on transaction details, etc?

Copy link
Contributor Author

@Jibz1 Jibz1 May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add other event logs later. Just started with default page view

@apburnie apburnie force-pushed the explorer-analytics-cookies branch from 3737d92 to 2ce5520 Compare May 24, 2022 14:12
@apburnie apburnie enabled auto-merge (squash) May 24, 2022 14:13
@apburnie apburnie merged commit 678340d into main May 24, 2022
@apburnie apburnie deleted the explorer-analytics-cookies branch May 24, 2022 14:15
666lcz pushed a commit that referenced this pull request May 27, 2022
* added GA4 to explorer

* License added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants