refactor(indexer-alt): remove dependency on mysten-metrics #20499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Part of the preparation for factoring out the indexer framework and schema. Removing a dependency on `mysten-metrics` because this is probably not something we want people outside of Mysten to depend on, and it is used in code that would be factored into the indexer framework. This means we lose some metrics related to thread stalls, and number of tracked tasks, but as far as I'm aware, we don't rely on these metrics anywhere. ## Test plan CI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
8 tasks
gegaowp
approved these changes
Dec 4, 2024
I don't quite understand why this is important. The indexer framework would already has a lot of dependencies to other crates, what is special about mysten-metrics? |
It does, but this is probably the only dependency that it had which was really an "internal" dependency, where people might make changes to this crate without taking into account that it's used by people outside |
amnn
added a commit
that referenced
this pull request
Dec 4, 2024
## Description Pull out the parts of `sui-indexer-alt` that can be used to create any indexer, in `sui-indexer-alt-framework`. Also take this opportunity to clean up dependencies and lock down visibilities between projects. ## Test plan CI ## Stack - #20499 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of the preparation for factoring out the indexer framework and schema. Removing a dependency on
mysten-metricsbecause this is probably not something we want people outside of Mysten to depend on, and it is used in code that would be factored into the indexer framework.This means we lose some metrics related to thread stalls, and number of tracked tasks, but as far as I'm aware, we don't rely on these metrics anywhere.
Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.