[kv store] add watermark table to bigtable #20390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
reviewed
Nov 22, 2024
| Some((key_bytes, _)) => Ok(u64::from_be_bytes(key_bytes.as_slice().try_into()?)), | ||
| None => Ok(0), | ||
| } | ||
| self.get_watermark(AGGREGATED_WATERMARK_NAME).await |
There was a problem hiding this comment.
Can you explain what "AGGREGATED_WATERMARK_NAME" is and why we wouldn't use the checkpoint task name? Or do we just have 1 "task" that is responsible for all the bigtable writes?
There was a problem hiding this comment.
yeah, we have a single task for all BigTable writes.
On the sui-data-ingestion side, DDB will be eventually replaced with BigTable, so our instance will store multiple entries for different workflows (e.g., archival, blob storage, etc.).
For community deployments, however, there will be only a single entry
bmwill
approved these changes
Nov 22, 2024
phoenix-o
added a commit
to phoenix-o/sui
that referenced
this pull request
Dec 18, 2024
This reverts commit 7eadb13.
phoenix-o
added a commit
that referenced
this pull request
Dec 18, 2024
This reverts commit 7eadb13. ## Description The hot row-hot cell pattern significantly slows down writes to Bigtable, impacting the ingestion speed of core pipelines --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds a watermark table to BigTable. The internal workflow progress store now writes watermarks to both DynamoDB and BigTable. In the future, the DynamoDB progress store will be deprecated
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.