-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use nextest for running rust tests #2031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good idea to use nextest indeed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I made a couple suggestions.
# - uses: bmwill/rust-cache@v1 # Fork of 'Swatinem/rust-cache' which allows caching additional paths | ||
# with: | ||
# path: ~/.cargo/registry/src/**/librocksdb-sys-* | ||
- uses: taiki-e/install-action@nextest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the latest advice is to use baptiste0928/cargo-installdue to its superior caching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually downloading pre-compiled binary so caching isn't even needed.
cargo build --all-features --lib | ||
cargo test --all-features --no-run # -j N # uncomment and set a low number if builds start OOMing again | ||
cargo test --all-features | ||
cargo nextest run --all-features --profile ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to use the --config-file
option here to make sure our custom config file is always taken into account? (w/o relying on default location that is, since it's relative to the workspace root .. imagine if we move everything to crates/
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with everything moved to crates/ directory we'd still keep the repo root as the workspace root I'd think
[profile.ci.junit] | ||
path = "junit.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what we would use this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generates a junit file that could be later used in order to analyze the test run to do things like open up issues for flaky tests, etc
It's unused now
No description provided.