Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-alt: remove watermarks.epoch_lo #20218

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

amnn
Copy link
Member

@amnn amnn commented Nov 11, 2024

Description

This field turns out not to be used by the new pruner implementation, because it is entirely based on checkpoints.

Test plan

CI

Stack


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@amnn amnn self-assigned this Nov 11, 2024
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 2:03pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 2:03pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 2:03pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 2:03pm

@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env November 11, 2024 13:49 — with GitHub Actions Inactive
@amnn
Copy link
Member Author

amnn commented Nov 11, 2024

@wlmyng, I'm particularly curious to get your take here as the originator of the initial watermarks schema -- can we get rid of this field, or does it still serve a purpose somewhere in a world where pruning is all checkpoint-based?

Copy link
Contributor

@wlmyng wlmyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine to remove, used only on production indexer for the pruning lower bound

## Description

This field turns out not to be used by the new pruner implementation,
because it is entirely based on checkpoints.

## Test plan

CI
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env November 13, 2024 14:00 — with GitHub Actions Inactive
@amnn amnn merged commit d337998 into amnn/idx-config Nov 13, 2024
34 of 41 checks passed
@amnn amnn deleted the amnn/idx-rm-epoch-lo branch November 13, 2024 14:00
amnn added a commit that referenced this pull request Nov 13, 2024
## Description

This field turns out not to be used by the new pruner implementation,
because it is entirely based on checkpoints.

## Test plan

CI

## Stack 

- #20149 
- #20150 
- #20166 
- #20216 
- #20217 

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants