Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consensus] soft bundle to be included on a block atomically #20215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akichidis
Copy link
Contributor

@akichidis akichidis commented Nov 11, 2024

Description

Following the work of #19572 , this PR is ensuring that a soft bundle will atomically be included in a consensus block. That:

  1. Strengthens the guarantees around the soft bundle sequencing to allow them processed in exact sequence and not break in multiple blocks.
  2. allow us to simply retry transactions of GC'ed blocks as we just retry all the transactions of softbundle

Kept the solution simple for now and if a soft bundle doesn't fit to a block then it's cached and is added to the next block.

Test plan

CI


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 1:00pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 1:00pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 1:00pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 1:00pm

@akichidis akichidis temporarily deployed to sui-typescript-aws-kms-test-env November 11, 2024 13:06 — with GitHub Actions Inactive
@akichidis akichidis force-pushed the akichidis/consensus-gc-5-soft-bundle branch from c99eb95 to 14156d4 Compare November 11, 2024 22:18
@akichidis akichidis temporarily deployed to sui-typescript-aws-kms-test-env November 11, 2024 22:18 — with GitHub Actions Inactive
Base automatically changed from akichidis/consensus-gc-5 to main November 13, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant