Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move-compiler] Improve interactions with Sui mode and interface files #20196

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

tnowacki
Copy link
Contributor

@tnowacki tnowacki commented Nov 6, 2024

Description

  • Sui mode used only named addresses for type comparison. This is not sufficient for interface files that might be using only the numerical address.
  • Switched is to use only the numerical address. We might want to evaluate differently if we start using it more outside of Sui mode

Test plan

  • Ran tests

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@tnowacki tnowacki requested a review from a team November 6, 2024 23:07
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:50pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 6:50pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 6:50pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 6:50pm

Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

@tnowacki tnowacki merged commit ec6d016 into MystenLabs:main Nov 12, 2024
48 checks passed
@tnowacki tnowacki deleted the addrnum branch November 12, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants