-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[indexer-alt] Add checkpoint ingestion lag metrics #20191
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
835cae5
to
dcff15a
Compare
c546a4b
to
db503ff
Compare
dcff15a
to
2799393
Compare
2799393
to
304ba49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- out of interest, why the different unit between the two metrics? (seconds vs milliseconds?)
The latest lag metric has to be in milleseconds because it's an int. |
Description
This PR adds two metrics, one that tracks the ingestion lag on the latest fetched checkpoint, one that tracks histogram. These two combined could give us the full picture on the lag.
Test plan
CI.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.