Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexer-alt] Add checkpoint ingestion lag metrics #20191

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Nov 6, 2024

Description

This PR adds two metrics, one that tracks the ingestion lag on the latest fetched checkpoint, one that tracks histogram. These two combined could give us the full picture on the lag.

Test plan

CI.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 7:08pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 7:08pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 7:08pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 7:08pm

@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 17:36 — with GitHub Actions Inactive
@lxfind lxfind force-pushed the indexer-alt-add-ingest-lag-metric branch from 835cae5 to dcff15a Compare November 6, 2024 17:36
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env November 6, 2024 17:37 — with GitHub Actions Inactive
@lxfind lxfind force-pushed the indexer-alt-add-latest-ingested-checkpoint-metric branch 2 times, most recently from c546a4b to db503ff Compare November 11, 2024 17:40
Base automatically changed from indexer-alt-add-latest-ingested-checkpoint-metric to main November 11, 2024 18:13
@lxfind lxfind force-pushed the indexer-alt-add-ingest-lag-metric branch from dcff15a to 2799393 Compare November 11, 2024 18:47
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env November 11, 2024 18:47 — with GitHub Actions Inactive
@lxfind lxfind force-pushed the indexer-alt-add-ingest-lag-metric branch from 2799393 to 304ba49 Compare November 11, 2024 19:06
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env November 11, 2024 19:06 — with GitHub Actions Inactive
@lxfind lxfind changed the title [indexer-alt] Add ingested_checkpoint_timestamp_lag_ms metric [indexer-alt] Add checkpoint ingestion lag metrics Nov 11, 2024
@lxfind lxfind requested a review from amnn November 11, 2024 19:10
Copy link
Member

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- out of interest, why the different unit between the two metrics? (seconds vs milliseconds?)

@lxfind
Copy link
Contributor Author

lxfind commented Nov 12, 2024

why the different unit between the two metrics? (seconds vs milliseconds?)

The latest lag metric has to be in milleseconds because it's an int.
The histogram could be either, and I chose seconds to be consistent with other seconds buckets. I don't have a strong opinion on this one.

@lxfind lxfind merged commit c4afb26 into main Nov 12, 2024
54 of 56 checks passed
@lxfind lxfind deleted the indexer-alt-add-ingest-lag-metric branch November 12, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants