[move-ide] Fixed auto-completion on the dot character #20175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
reviewed
Nov 5, 2024
cgswords
reviewed
Nov 5, 2024
| @@ -393,6 +393,7 @@ pub enum Exp_ { | |||
| /* is_macro */ Option<Loc>, | |||
| Option<Vec<Type>>, | |||
| Spanned<Vec<Exp>>, | |||
| Loc, // location of the dot | |||
There was a problem hiding this comment.
Put Loc between the boxed expression and the name.
cgswords
reviewed
Nov 5, 2024
| @@ -336,7 +336,7 @@ pub type LambdaLValues = Spanned<LambdaLValues_>; | |||
| #[allow(clippy::large_enum_variant)] | |||
| pub enum ExpDotted_ { | |||
| Exp(Box<Exp>), | |||
| Dot(Box<ExpDotted>, Name), | |||
| Dot(Box<ExpDotted>, Name, Loc), | |||
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
reviewed
Nov 13, 2024
Comment on lines
+3427
to
+3432
| if context.env.ide_mode() { | ||
| if let Some(mdot_loc) = method_dot_loc { | ||
| ide_report_autocomplete(context, &mdot_loc, &edotted_ty); | ||
| } | ||
| } | ||
| result |
There was a problem hiding this comment.
This check is redundant.
Suggested change
| if context.env.ide_mode() { | |
| if let Some(mdot_loc) = method_dot_loc { | |
| ide_report_autocomplete(context, &mdot_loc, &edotted_ty); | |
| } | |
| } | |
| result | |
| if let Some(mdot_loc) = method_dot_loc { | |
| ide_report_autocomplete(context, &mdot_loc, &edotted_ty); | |
| } | |
| result |
cgswords
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a certain problem with auto-completion on the
.character. Previously, once a part of the access chain after the.was parsed, auto-completion information for the.character location was no longer generated. This is particularly problematic if someone expects auto-completion in the middle of the function code, for example:It is expected that auto-completion would work correctly after
val.but previously it did not because this expression was actually parsed asval.SomeStruct. This PR fixes this:Previously, auto-completion for the
.location would also not work if what follows the.is a function call (whether the function being called was resolved correctly or not). It now works correctly in both cases:Test plan
All new and (updated) all tests must pass