indexer: stop indexing tx_input_objects and tx_changed_objects #19820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lxfind
approved these changes
Oct 11, 2024
amnn
force-pushed
the
amnn/idx-write-rm-send-recv
branch
from
446e5f3 to
d71f099
Compare
amnn
force-pushed
the
amnn/idx-write-rm-input-changed
branch
from
5c8d5d1 to
28f9281
Compare
amnn
force-pushed
the
amnn/idx-write-rm-send-recv
branch
from
d71f099 to
64d39ef
Compare
amnn
force-pushed
the
amnn/idx-write-rm-input-changed
branch
from
28f9281 to
a8adfc7
Compare
bmwill
approved these changes
Oct 11, 2024
…tionBlockRelation.RECV ## Description These fields were flagged for deprecation in 1.34 and have been replaced in 1.35 by - `TransactionBlockFilter.affectedAddress` and - `AddressTransactionBlockRelation.AFFECTED` Which offer a similar (but not exactly the same) semantics, but without confusion around the sender address which was often also an implicit recipient of a transaction. ## Test plan ``` sui$ cargo nextest run -p sui-graphql-rpc sui$ cargo nextest run -p sui-graphql-rpc --features staging sui$ cargo nextest run -p sui-graphql-e2e-tests ```
## Description All references to these fields have been removed from readers, so we can stop keeping it up-to-date. Once this change lands, we can also clean these tables from the schema. ## Test plan ``` sui$ cargo nextest run -p sui-indexer ```
## Description Stop indexing these tables in favour of `tx_affected_objects`. This change cannot land without GraphQL first being updated to avoid reading these tables (otherwise its tests will fail as these fields are no longer indexed), but the PR is being put out early for experimentation. ## Test plan ``` sui$ cargo nextest run -p sui-indexer ```
amnn
force-pushed
the
amnn/idx-write-rm-send-recv
branch
from
64d39ef to
c35ff47
Compare
amnn
force-pushed
the
amnn/idx-write-rm-input-changed
branch
from
a8adfc7 to
08b5a6b
Compare
gegaowp
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop indexing these tables in favour of
tx_affected_objects. This change cannot land without GraphQL first being updated to avoid reading these tables (otherwise its tests will fail as these fields are no longer indexed), but the PR is being put out early for experimentation.Test plan
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.