Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[framework] output human readable debug in std::unit_test #19632

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Sep 30, 2024

Description

This is what we have today when using assert_eq!

[debug] 0x417373657274696f6e206661696c65643a
[debug] 2000
[debug] 0x213d
[debug] 1000

This is what we really want:

[debug] Assertion failed:
[debug] 2000
[debug] !=
[debug] 1000

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@damirka damirka self-assigned this Sep 30, 2024
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 9:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Sep 30, 2024 9:12pm
sui-kiosk ⬜️ Ignored (Inspect) Sep 30, 2024 9:12pm
sui-typescript-docs ⬜️ Ignored (Inspect) Sep 30, 2024 9:12pm

@damirka damirka changed the title we did it [framework] Output human readable debug in std::unit_test Sep 30, 2024
@damirka damirka changed the title [framework] Output human readable debug in std::unit_test [framework] output human readable debug in std::unit_test Sep 30, 2024
@damirka damirka merged commit ff9e78f into main Sep 30, 2024
50 of 54 checks passed
@damirka damirka deleted the ds/debug-annoy branch September 30, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants