Deepbook Locked Balance SDK #19557
Merged
Deepbook Locked Balance SDK #19557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }); | ||
|
|
||
| const baseLocked = Number(bcs.U64.parse(new Uint8Array(res.results![0].returnValues![0][0]))); | ||
| const quoteLocked = Number(bcs.U64.parse(new Uint8Array(res.results![0].returnValues![1][0]))); |
There was a problem hiding this comment.
These are all unsafe number conversions fwiw, should be using bigint
There was a problem hiding this comment.
Will address in an improvement PR outside this one, for now rounding to 9 decimals
There was a problem hiding this comment.
You'll actually have the precision issue before you do the division because JS can only represent numbers up to 2^53 - 1, but fine to punt.
0xaslan
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Locked balance function for sdk
Test plan
Testnet
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.