fix(core): deserialize malformed types in tx #19446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Make it possible to represent a transaction that includes a bad type (a type that does not parse correctly). Such transactions will fail to execute but may exist on-chain and so we need to be able to represent them. To avoid confusion in future, we will perform an early (signing) check for type correctness, preventing more examples of this pattern from appearing on-chain. GraphQL has also been updated so that it can represent such a transaction without emitting an error. ## Test plan ``` sui$ cargo simtest sui$ cargo nextest run -p sui-graphql-rpc sui$ cargo nextest run -p sui-graphql-e2e-tests ```
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz,
suiwombat and
mystenmark
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bmwill
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it possible to represent a transaction that includes a bad type (a type that does not parse correctly). Such transactions will fail to execute but may exist on-chain and so we need to be able to represent them.
To avoid confusion in future, we will perform an early (signing) check for type correctness, preventing more examples of this pattern from appearing on-chain.
GraphQL has also been updated so that it can represent such a transaction without emitting an error.
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
MoveTypecan fail to provide a layout or abilities in cases where it represents an unparseable type.