Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move-ide] Refactored auto-completions implementation to multiple files #19236

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

awelc
Copy link
Contributor

@awelc awelc commented Sep 5, 2024

Description

The auto-completions implementation was becoming unwieldy and this PR splits it up to multiple files in a separate directory. This a pure refactoring - other than some name changes, added comments, and moving code around, no modifications have been made

Test plan

All existing tests must pass

@awelc awelc self-assigned this Sep 5, 2024
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 10:50pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Sep 5, 2024 10:50pm
sui-kiosk ⬜️ Ignored (Inspect) Sep 5, 2024 10:50pm
sui-typescript-docs ⬜️ Ignored (Inspect) Sep 5, 2024 10:50pm

Copy link
Contributor

@rvantonder rvantonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ship it~

@awelc awelc merged commit 5b7f117 into main Sep 10, 2024
49 checks passed
@awelc awelc deleted the aw/ide-completions-refactor branch September 10, 2024 19:53
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
…es (#19236)

## Description 

The auto-completions implementation was becoming unwieldy and this PR
splits it up to multiple files in a separate directory. This a pure
refactoring - other than some name changes, added comments, and moving
code around, no modifications have been made

## Test plan 

All existing tests must pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants