feat: add to_string to numbers #19119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
damirka
reviewed
Aug 28, 2024
| @@ -57,6 +59,19 @@ module std::u16 { | |||
| std::macros::num_sqrt!<u16, u32>(x, 16) | |||
| } | |||
|
|
|||
| public fun to_string(mut value: u16): String { | |||
There was a problem hiding this comment.
Make it a macro similar to other functions in uN modules.
|
fixed, sorry for not paying attention to the new implementation! |
damirka
reviewed
Aug 29, 2024
crates/sui-framework/packages/move-stdlib/tests/integer_tests.move
Outdated
Show resolved
Hide resolved
damirka
reviewed
Aug 29, 2024
damirka
reviewed
Aug 29, 2024
This was referenced Aug 29, 2024
8 tasks
dariorussi
added a commit
that referenced
this pull request
Aug 29, 2024
This reverts commit df95820.
jangid
pushed a commit
to jangid/sui
that referenced
this pull request
Aug 30, 2024
## Description Adds `to_string` to integer modules (`u8`->`u256`) ## Test plan Features tests. --- ## Release notes * unsigned integers now support `.to_string()` methods, for example `10u8.to_string()` is the same as `b"10".to_string()` - [x] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description Adds `to_string` to integer modules (`u8`->`u256`) ## Test plan Features tests. --- ## Release notes * unsigned integers now support `.to_string()` methods, for example `10u8.to_string()` is the same as `b"10".to_string()` - [x] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
to_stringto integer modules (u8->u256)Test plan
Features tests.
Release notes
unsigned integers now support
.to_string()methods, for example10u8.to_string()is the same asb"10".to_string()