[move] Rewrite verifier metering #19036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tnowacki is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tnowacki
force-pushed
the
verifier-rewrite
branch
from
d7f3e52 to
383823b
Compare
tzakian
reviewed
Aug 21, 2024
| @@ -161,8 +161,10 @@ macro_rules! safe_unwrap { | |||
| match $e { | |||
| Some(x) => x, | |||
| None => { | |||
| let err = PartialVMError::new(StatusCode::UNKNOWN_INVARIANT_VIOLATION_ERROR) | |||
| .with_message(format!("{}:{} (none)", file!(), line!())); | |||
| let err = move_binary_format::errors::PartialVMError::new( | |||
There was a problem hiding this comment.
Nit: consider importing these modules instead of fully qualifying them.
There was a problem hiding this comment.
This is in a macro declaration. I feel like maybe the fully qualified paths are more clear?
There was a problem hiding this comment.
ah! didn't realize that. Makes sense to keep as-is then.
| pub(crate) const RET_PER_LOCAL_COST: u128 = 30; | ||
| pub(crate) const JOIN_BASE_COST: u128 = 10; | ||
| pub(crate) const JOIN_PER_LOCAL_COST: u128 = 5; | ||
| use crate::ability_cache::AbilityCache; |
There was a problem hiding this comment.
nit: move use up to the other use statements?
There was a problem hiding this comment.
Remember what we were discussing about autoimports in the IDE... yeah this is why its hard
| function_context: &FunctionContext, | ||
| ability_ache: &mut AbilityCache, |
external-crates/move/crates/move-bytecode-verifier/src/reference_safety/abstract_state.rs
Show resolved
Hide resolved
external-crates/move/crates/move-bytecode-verifier/src/reference_safety/abstract_state.rs
Show resolved
Hide resolved
Comment on lines
29
to
30
| module_ability_cache: RefCell<&'a mut AbilityCache<'env>>, | ||
| meter: RefCell<&'b mut M>, |
There was a problem hiding this comment.
Is there a particular reason for these RefCells? Would be nice if they weren't needed.
tnowacki
force-pushed
the
verifier-rewrite
branch
from
383823b to
b9d9d9a
Compare
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Aug 27, 2024
## Description - Added ability cache for verifier ability queries - Redid metering for typing, local safety, and reference safety ## Test plan - calibrated constants --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description - Added ability cache for verifier ability queries - Redid metering for typing, local safety, and reference safety ## Test plan - calibrated constants --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.