Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Add further support for enums in Move model #18980

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented Aug 13, 2024

Description

Fixes a bug in the Move model around enums, and does a small bit of cleanup in that area.

Test plan

Added a new test for the scenario.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@tzakian tzakian requested a review from a team August 13, 2024 23:29
@tzakian tzakian requested a review from ronny-mysten as a code owner August 13, 2024 23:29
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 11:31pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Aug 13, 2024 11:31pm
sui-kiosk ⬜️ Ignored (Inspect) Aug 13, 2024 11:31pm
sui-typescript-docs ⬜️ Ignored (Inspect) Aug 13, 2024 11:31pm

@tzakian tzakian merged commit 9c4652f into main Aug 14, 2024
48 checks passed
@tzakian tzakian deleted the tzakian/fix-enums-move-model-3 branch August 14, 2024 01:42
Copy link
Contributor

@ronny-mysten ronny-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post merge, but lgtm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants