Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isValidating state from showing invalid address #18963

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Jibz-Mysten
Copy link
Contributor

@Jibz-Mysten Jibz-Mysten commented Aug 12, 2024

Description

Prevent showing errors during isValidator.

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@Jibz-Mysten Jibz-Mysten requested a review from a team as a code owner August 12, 2024 20:37
@Jibz-Mysten Jibz-Mysten requested review from williamrobertson13 and mystieanwaya and removed request for a team August 12, 2024 20:37
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 8:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Skipped (Inspect) Aug 12, 2024 8:39pm
sui-kiosk ⬜️ Skipped (Inspect) Aug 12, 2024 8:39pm
sui-typescript-docs ⬜️ Skipped (Inspect) Aug 12, 2024 8:39pm

@Jibz-Mysten Jibz-Mysten merged commit 88d4fd4 into main Aug 12, 2024
51 checks passed
@Jibz-Mysten Jibz-Mysten deleted the gj-fix-validating-address-name branch August 12, 2024 22:09
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
## Description 

Prevent showing errors during isValidator.




Describe the changes or additions included in this PR.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants