Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explorer] Implements 'Static' Mode and Tests for Transaction Results #1883

Merged
merged 13 commits into from
May 11, 2022
Merged

[explorer] Implements 'Static' Mode and Tests for Transaction Results #1883

merged 13 commits into from
May 11, 2022

Conversation

apburnie
Copy link
Contributor

@apburnie apburnie commented May 10, 2022 •
edited
Loading

Purpose of PR is to fix #1264 as well as refactoring the codebase.

Specifics:

  • Re-implements UI tests for Transaction Results.
  • Enables manually varying static transaction data to see effect on UI. In this example can see what Failure looks like.
  • Re-instigates the passing of state when searching for a transaction
  • Removes redundant smart contract placeholder code
  • Removes redundant yarn packages

@apburnie apburnie marked this pull request as ready for review May 11, 2022 15:18
@apburnie apburnie requested review from stella3d, 666lcz and Jibz1 May 11, 2022 16:18
stella3d
stella3d suggested changes May 11, 2022
View reviewed changes
Copy link
Contributor

@stella3d stella3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good but i'm getting errors with the latest transactions card when i test.

spin up your localhost to test - the actual network request to DevNet for latest transactions is coming back fine, so it's something on the frontend.
image

explorer/client/src/components/displaybox/DisplayBox.tsx
//import 'ace-builds/src-noconflict/theme-github';
//import AceEditor from 'react-ace';

function SmartContractBox({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see this removed, good cleanup

@stella3d
Copy link
Contributor

code looks good but i'm getting errors with the latest transactions card when i test.

spin up your localhost to test - the actual network request to DevNet for latest transactions is coming back fine, so it's something on the frontend. image

using --force to reinstall dependencies and get the latest version of the TS SDK did fix this, but why ?

@apburnie apburnie merged commit 5835515 into main May 11, 2022
@apburnie apburnie deleted the andrew/TransactionResultsTestSuite branch May 11, 2022 17:48
@tardigrade34 tardigrade34 mentioned this pull request Apr 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stella3d stella3d stella3d approved these changes

@666lcz 666lcz Awaiting requested review from 666lcz

@Jibz1 Jibz1 Awaiting requested review from Jibz1

Assignees
No one assigned
Labels
sui-explorer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[explorer] Create Test Suite for Transaction Results
2 participants
@apburnie @stella3d