Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet ui project initialisation #1845

Merged
merged 1 commit into from
May 9, 2022
Merged

wallet ui project initialisation #1845

merged 1 commit into from
May 9, 2022

Conversation

pchrysochoidis
Copy link
Contributor

@pchrysochoidis pchrysochoidis commented May 5, 2022

  • app shows an under construction message (in popup and new tab)
  • after installing the extension, a new tab will open with the app
  • build tools: webpack, typescript, eslint, stylelint & prettier
  • the ui part is a react app
Screen.Recording.2022-05-06.at.16.09.18.mov

Screenshot 2022-05-06 at 16 07 32

Screenshot 2022-05-06 at 16 07 59

Screenshot 2022-05-06 at 16 08 16

Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's start building the interesting things

@666lcz
Copy link
Contributor

666lcz commented May 5, 2022

The build error is that you need to add license header to all files

@pchrysochoidis pchrysochoidis force-pushed the pc-wallet-ui-init branch 2 times, most recently from 1a382db to 0f34ca2 Compare May 6, 2022 10:55
* app shows an `under construction` message (in popup and new tab)
* after installing the extension, a new tab will open with the app
* build tools: webpack, typescript, eslint, stylelint & prettier
* the ui part is a react app
@pchrysochoidis pchrysochoidis changed the title wallet UI init wallet ui project initialisation May 6, 2022
@pchrysochoidis pchrysochoidis marked this pull request as ready for review May 6, 2022 15:42
@pchrysochoidis pchrysochoidis requested a review from 666lcz May 6, 2022 15:42
Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the screenshot and the video as well as the README!

@pchrysochoidis pchrysochoidis merged commit 65716da into main May 9, 2022
@pchrysochoidis pchrysochoidis deleted the pc-wallet-ui-init branch May 9, 2022 09:38
@666lcz 666lcz mentioned this pull request May 24, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants