[stdlib] Adds macros for option #18421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tnowacki
approved these changes
Jun 28, 2024
Comment on lines
+156
to
+158
| if (o.is_some()) { | ||
| $f(o.destroy_some()); | ||
| } |
There was a problem hiding this comment.
style nit
Suggested change
| if (o.is_some()) { | |
| $f(o.destroy_some()); | |
| } | |
| if (o.is_some()) $f(o.destroy_some()) |
Comment on lines
+164
to
+166
| if (o.is_some()) { | ||
| $f(o.borrow()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (o.is_some()) { | |
| $f(o.borrow()); | |
| } | |
| if (o.is_some()) $f(o.borrow()) |
| /// Execute a closure on the mutable reference to the value inside `t` if it holds one. | ||
| public macro fun do_mut<$T>($o: &mut Option<$T>, $f: |&mut $T|) { | ||
| let o = $o; | ||
| if (o.is_some()) $f(o.borrow_mut()); |
There was a problem hiding this comment.
Suggested change
| if (o.is_some()) $f(o.borrow_mut()); | |
| if (o.is_some()) $f(o.borrow_mut()) |
Comment on lines
+179
to
+180
| if (o.is_some()) o | ||
| else $default |
| /// Return `None` if the value is `None`, otherwise return `Option<T>` if the predicate `f` returns true. | ||
| public macro fun filter<$T: drop>($o: Option<$T>, $f: |&$T| -> bool): Option<$T> { | ||
| let o = $o; | ||
| if (o.is_some() && $f(o.borrow())) o |
There was a problem hiding this comment.
Beautiful, love how this one turned out
| option::some(5).destroy!(|x| counter = x); | ||
| option::some(10).do!(|x| counter = counter + x); | ||
|
|
||
| assert!(counter == 15); |
There was a problem hiding this comment.
I snuck in std::unit_test::assert_eq a while back if you want to give it a shot. This is fine though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds macros for option, currently, contains
doanddestroy(identical).Test plan
Features tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.