split-cluster-check - Verify that DKG completes if enabled #18333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
benr-ml
changed the title
mystenmark
reviewed
Jun 20, 2024
| @@ -98,6 +98,20 @@ if ! grep -q "Node State has been reconfigured" "$LOG_DIR/fullnode.log"; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # ensure that the random beacon's DKG completes on both versions. | |||
There was a problem hiding this comment.
fwiw i don't see how it could complete in one, but not the other, since it should cause a fork in that case.
mystenmark
approved these changes
Jun 20, 2024
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
…s#18333) ## Description Verify that DKG completes after the reconf in split-cluster-check. Also add a more concrete log for 'DKG start' event, to be used in the future in the above verification. ## Test plan manually tested --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verify that DKG completes after the reconf in split-cluster-check.
Also add a more concrete log for 'DKG start' event, to be used in the future in the above verification.
Test plan
manually tested
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.